autour_de_minuit/rig_picker
9
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: shape geometry link behavior. #2

Merged
jonas.holzman merged 2 commits from swann.martinez/rig_picker:fix-collection-link-for-create-shape into master 2025-06-27 16:17:09 +02:00
Conversation 1 Commits 2 Files Changed 1 +4 -5
swann.martinez commented 2025-06-24 18:04:14 +02:00
Contributor
Copy Link

Modifications

Before the patch, shapes were systematically linked to the scene's main collection (Maybe that's the way it's supposed to be?), regardless of the collection selection. The patch changes this to link geometry only if no canvas collection is selected.

Example

This shape creation command :
image.png

Result before the patch:
image.png

Result after the patch:
image.png

How to test it

  1. Open Blender 4.0
  2. Test the rig picker shape creation on an asset
## Modifications Before the patch, shapes were systematically linked to the scene's main collection (Maybe that's the way it's supposed to be?), regardless of the collection selection. The patch changes this to link geometry only if no canvas collection is selected. ## Example This shape creation command : ![image.png](/attachments/6dac5833-b5a1-4fd9-af7f-6d1b12f8f14a) Result before the patch: ![image.png](/attachments/ff0ad9fd-4ec4-47af-acdd-668803133158) Result after the patch: ![image.png](/attachments/fcf52873-d713-48a5-b397-0584d20caae5) ## How to test it 1. Open Blender 4.0 2. Test the rig picker shape creation on an asset
image.png
26 KiB
image.png
20 KiB
image.png
17 KiB
swann.martinez added 1 commit 2025-06-24 18:04:18 +02:00 
Before the patch, shapes were systematically linked to the scene's main collection, regardless of the collection selection. The patch changes this to link geometry only if no canvas collection is selected.
swann.martinez added 1 commit 2025-06-24 18:09:01 +02:00
jonas.holzman approved these changes 2025-06-27 16:16:20 +02:00
jonas.holzman left a comment
Owner
Copy Link

Thanks Swann :) LGTM!

Thanks Swann :) LGTM!
❤️ 1
jonas.holzman merged commit c7df358fe8 into master 2025-06-27 16:17:09 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
jonas.holzman
Labels
Clear labels
done
Sujet résolu
hold
Sujet en pause
rejected
Sujet refusé ou abandonné
rtk
Sujet en retake
todo
Sujet a faire
wfa
Sujet en attente de validation
wip
Sujet actuellement pris en charge par un TD
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admindns christophe.seux clement.ducarteron florentin.luce jonas.holzman mario.hawat samuel.bernou
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: autour_de_minuit/rig_picker#2
No description provided.
Delete Branch "swann.martinez/rig_picker:fix-collection-link-for-create-shape"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?